pimp-up-gui #5

Manually merged
rob merged 3 commits from pimp-up-gui into main 2026-09-09 15:01:58 +02:00
Collaborator
No description provided.
Inline SVG in index.html and in JS template literals moves to 52 standalone
icon files, referenced as <use href="assets/icons/<name>.svg#i">. Chosen over
<img> so currentColor and the theme CSS still reach the artwork.

- index.html: 55 icon sites now reference files. The playhead-toggle icon stays
  inline because transportUI.js and oscillaTransport.css target
  #playhead-icon-line / #playhead-icon-zone, which <use> hides in a shadow tree.
- drawing.js, oscillaTransport.js, playheadOffset.js: same for JS-built toolbars.
- Icons are coloured via `color` rather than `stroke`: only inherited properties
  cross the <use> shadow boundary, so the descendant selectors in
  oscillaLightTheme.css no longer reach icon shapes. Dark mode is the global
  invert filter, which applies to shadow content unchanged.
- Rehearsal marks / score notes / audio master get icons in place of the R/N/A
  letters, and the rehearsal button gains a tooltip it never had.
- scripts/normalize-icons.py strips exporter metadata (C2PA, Inkscape) and
  restores the #i anchor after an icon export, preserving groups and transforms.
  Verify with --self-test.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
#speedControls (id) and .speed-panel (class) both styled the same element, so
the id silently won: gap:0 killed the panel's gap at base, and padding-left
overrode only one side of .speed-panel's symmetric padding. The result was
buttons flush against each other inside a box with ~2x more padding on the
left, at every breakpoint.

Spacing now lives on #speedControls alone, which wins either way, and
.speed-panel keeps just its symmetric padding. The outer 20px separating the
panel from the seek cluster becomes margin-left, so it no longer eats into the
panel's own bordered box.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
rob closed this pull request 2026-09-09 14:45:10 +02:00
filip reopened this pull request 2026-09-09 14:52:21 +02:00
rob manually merged commit d80c16069f into main 2026-09-09 15:01:58 +02:00
filip deleted branch pimp-up-gui 2026-09-09 15:23:52 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rob/oscilla!5
No description provided.